Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #156
replaces #157
This package passed loops around a lot, this was mainly required for tests to pass with python < 3.5.2 where
set_event_loop
didn't work properly.This in turn was causing problems with uvloop, either meaning the wrong loop was used or a "different loop" error occurred.
The fixes here can be demonstrated by the micro example
Run with
Should now return
loop: <uvloop.Loop running=True closed=False debug=False>
while before it was using the standard python loop.@vladiibine would be great if you could try this and confirm it works for you.